Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix robolectric test runtime failures due to large classpath w/ 1.5k+ entries #14887

Closed
wants to merge 0 commits into from
Closed

Fix robolectric test runtime failures due to large classpath w/ 1.5k+ entries #14887

wants to merge 0 commits into from

Conversation

oliviernotteghem
Copy link

fixes #14886

@sgowroji sgowroji added the team-Android Issues for Android team label Mar 24, 2022
@sgowroji sgowroji added the awaiting-review PR is awaiting review from an assigned reviewer label Apr 21, 2022
@sgowroji sgowroji requested a review from ahumesky April 21, 2022 05:01
@sgowroji sgowroji added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 21, 2022
@sgowroji
Copy link
Member

Hello @oliviernotteghem, Can you please fix build failures ? Thanks!

@oliviernotteghem
Copy link
Author

@sgowroji sgowroji : Sure. Failures were unrelated, I just rebased and checks have passed now. Thanks.

@Bencodes
Copy link
Contributor

There's another java launcher path that might need to be updated as well to mirror this logic https://github.com/bazelbuild/bazel/blob/master/src/tools/launcher/java_launcher.cc#L381-L386

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Apr 22, 2022
@oliviernotteghem
Copy link
Author

Sorry. Closed this by accident. Will re-open PR.

@ted-xie
Copy link
Contributor

ted-xie commented May 12, 2022

@oliviernotteghem Do you still want to re-open the PR? I see 0 files changed here.

@oliviernotteghem
Copy link
Author

@ted-xie : yes, I closed PR accidentally. Let me republish it. I will do it shortly today.

@oliviernotteghem oliviernotteghem mentioned this pull request May 12, 2022
Open
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahumesky ahumesky Awaiting requested review from ahumesky

Assignees
No one assigned
Labels
team-Android Issues for Android team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Robolectric / android_local_test runtime failures with NoClassDefFoundError caused by long classpath argument
5 participants
@oliviernotteghem @sgowroji @Bencodes @ted-xie @ShreeM01