Skip to content

Commit

Permalink
Add method to SkyframeExecutor which returns top-level analysis pha…
Browse files Browse the repository at this point in the history
…se keys.

PiperOrigin-RevId: 444878162
  • Loading branch information
Googler authored and copybara-github committed Apr 27, 2022
1 parent a48e246 commit 649521a
Showing 1 changed file with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -2244,11 +2244,20 @@ EvaluationResult<ActionLookupValue> configureTargets(
.build();
EvaluationResult<ActionLookupValue> result =
memoizingEvaluator.evaluate(
Iterables.concat(configuredTargetKeys, topLevelAspectKeys), evaluationContext);
analysisPhaseKeys(configuredTargetKeys, topLevelAspectKeys), evaluationContext);
perCommandSyscallCache.noteAnalysisPhaseEnded();
return result;
}

/**
* Returns top-level analysis phase keys, {@link ConfiguredTargetKey} and {@link
* TopLevelAspectsKey}.
*/
protected Iterable<? extends SkyKey> analysisPhaseKeys(
Iterable<ConfiguredTargetKey> ctKeys, Iterable<TopLevelAspectsKey> aspectKeys) {
return Iterables.concat(ctKeys, aspectKeys);
}

/**
* Evaluates the given collections of CT/Aspect BuildDriverKeys. This is part of
* https://github.com/bazelbuild/bazel/issues/14057, internal: b/147350683.
Expand Down

0 comments on commit 649521a

Please sign in to comment.