Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add breaking change note to 5.0.0 #14695

Closed
wants to merge 1 commit into from

Conversation

davidxia
Copy link

@davidxia davidxia commented Feb 2, 2022

No description provided.

davidxia referenced this pull request Feb 2, 2022
This allows us to simplify the code and remove the options from the lexer and parser.

#8380

PiperOrigin-RevId: 404799093
@davidxia
Copy link
Author

davidxia commented Feb 2, 2022

cc @laurentlb

@gregestren gregestren added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Feb 2, 2022
@Wyverald
Copy link
Member

Wyverald commented Feb 2, 2022

The changelog file is unfortunately a bit messed up for the 5.0 release (it does not contain any relnotes); we're trying to fix that for the next release. Unfortunately this PR doesn't really fix the problem either (the commit in question is not a cherry-pick; moreover, it only calls out this specific breaking change, implying there aren't any others). In the meantime, please refer to the blog post for 5.0.

@Wyverald Wyverald closed this Feb 2, 2022
@davidxia
Copy link
Author

davidxia commented Feb 2, 2022

Thanks for the quick response. The blog post doesn’t mention this breaking change either. Any chance it can be updated?

@davidxia
Copy link
Author

davidxia commented Feb 3, 2022

@Wyverald i'm happy to make a PR for the blog post to update it if that's possible. Lmk!

@davidxia davidxia deleted the changelog branch February 3, 2022 18:19
@Wyverald
Copy link
Member

Wyverald commented Feb 3, 2022

Sorry I missed your previous comment. Yes the blog post should be updatable (sample PR). I just realized this change didn't show up in any changelogs because it didn't correctly have the RELNOTES section in its commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants