Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update 5.0 post with breaking change #265

Merged
merged 1 commit into from
Feb 9, 2022
Merged

fix: update 5.0 post with breaking change #265

merged 1 commit into from
Feb 9, 2022

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Feb 3, 2022 •
edited
Loading

--incompatible_restrict_string_escapes was removed
here

cc @Wyverald

see bazelbuild/bazel#14695

@davidxia
fix: update 5.0 post with breaking change
0337f30 
`--incompatible_restrict_string_escapes` was removed
[here](bazelbuild/bazel@21b4b1a)
laurentlb
laurentlb approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Sorry for forgetting the relnotes.

@davidxia
Copy link
Contributor Author

davidxia commented Feb 9, 2022

Thanks, any next steps to merging this?

@Wyverald
Copy link
Member

Wyverald commented Feb 9, 2022

@aiuto thoughts?

@hicksjoseph hicksjoseph requested a review from Wyverald February 9, 2022 18:14
hicksjoseph
hicksjoseph approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@hicksjoseph hicksjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seems like a pretty straightforward change.

@hicksjoseph hicksjoseph merged commit 45e5759 into bazelbuild:master Feb 9, 2022
@davidxia davidxia deleted the patch-1 branch February 9, 2022 18:45
@aiuto
Copy link
Contributor

aiuto commented Feb 10, 2022

I think we have a process question here.
Why is anyone but a single release manager for all of 5.x reviewing anything related to 5.x?

@Wyverald
Copy link
Member

This is the blog. I mean I am fine with just approving and merging this blog post, but normally any blog post changes get reviewed by one of you guys, no?

If you're talking about the PRs against the 5.1 branch in bazelbuild/bazel, then yes, the release manager should be reviewing and merging them (as I have been). Sometimes Github automatically assigns reviewers due to CODEOWNERS, but there's not much we can do there.

@aiuto
Copy link
Contributor

aiuto commented Feb 11, 2022

A product manager should approve all blog posts. For now, that is Joe Hicks.
I didn't phrase myself well. It was more a question of why our approval process allows anyone else a reviewer.
We should clean up the codeowners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlb laurentlb laurentlb approved these changes

@hicksjoseph hicksjoseph hicksjoseph approved these changes

@aiuto aiuto Awaiting requested review from aiuto

@floriographygoth floriographygoth Awaiting requested review from floriographygoth

@jin jin Awaiting requested review from jin

@Wyverald Wyverald Awaiting requested review from Wyverald

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidxia @Wyverald @aiuto @laurentlb @hicksjoseph