Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence swiftmodule timestamp warnings #13165

Conversation

keith
Copy link
Member

@keith keith commented Mar 5, 2021

As part of #13091 dsymtuil started producing these warnings:

warning: Timestamp mismatch for bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-7786d55448f4/bin/Modules/DependencyInjection/DependencyInjection.swiftmodule: 2021-03-05 13:54:33.542331246 and 1969-12-31 16:00:00.000000000

In general we're happily ignoring this to get hermetic outputs instead (it's being compared against the file modification timestamp)

This change disables this warning.

It appears this feature has been around for at least 3 years swiftlang/llvm-project@2dd9848 so we should be good for all the versions of Xcode we support.

Relevant logic: https://github.com/apple/llvm-project/blob/902bb11a46eb82e81d7e8b34450481e143a208b2/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp#L407-L421

As part of bazelbuild#13091 dsymtuil started producing these warnings:

```
warning: Timestamp mismatch for bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-7786d55448f4/bin/Modules/DependencyInjection/DependencyInjection.swiftmodule: 2021-03-05 13:54:33.542331246 and 1969-12-31 16:00:00.000000000
```

In general we're happily ignoring this to get hermetic outputs instead (it's being compared against the file modification timestamp)

This change disables this warning.

It appears this feature has been around for at least 3 years swiftlang/llvm-project@2dd9848 so we should be good for all the versions of Xcode we support.

Relevant logic: https://github.com/apple/llvm-project/blob/902bb11a46eb82e81d7e8b34450481e143a208b2/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp#L407-L421
@google-cla google-cla bot added the cla: yes label Mar 5, 2021
@keith
Copy link
Member Author

keith commented Mar 22, 2021

@oquenchil can you review?

Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keith
Copy link
Member Author

keith commented Mar 31, 2021

@oquenchil thanks, can you help land this?

@bazel-io bazel-io closed this in 47edc57 Apr 1, 2021
philwo pushed a commit that referenced this pull request Apr 20, 2021
As part of #13091 dsymtuil started producing these warnings:

```
warning: Timestamp mismatch for bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-7786d55448f4/bin/Modules/DependencyInjection/DependencyInjection.swiftmodule: 2021-03-05 13:54:33.542331246 and 1969-12-31 16:00:00.000000000
```

In general we're happily ignoring this to get hermetic outputs instead (it's being compared against the file modification timestamp)

This change disables this warning.

It appears this feature has been around for at least 3 years swiftlang/llvm-project@2dd9848 so we should be good for all the versions of Xcode we support.

Relevant logic: https://github.com/apple/llvm-project/blob/902bb11a46eb82e81d7e8b34450481e143a208b2/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp#L407-L421

Closes #13165.

PiperOrigin-RevId: 366215825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants