Skip to content

Commit

Permalink
Silence swiftmodule timestamp warnings
Browse files Browse the repository at this point in the history
As part of #13091 dsymtuil started producing these warnings:

```
warning: Timestamp mismatch for bazel-out/ios-x86_64-min11.0-applebin_ios-ios_x86_64-fastbuild-ST-7786d55448f4/bin/Modules/DependencyInjection/DependencyInjection.swiftmodule: 2021-03-05 13:54:33.542331246 and 1969-12-31 16:00:00.000000000
```

In general we're happily ignoring this to get hermetic outputs instead (it's being compared against the file modification timestamp)

This change disables this warning.

It appears this feature has been around for at least 3 years swiftlang/llvm-project@2dd9848 so we should be good for all the versions of Xcode we support.

Relevant logic: https://github.com/apple/llvm-project/blob/902bb11a46eb82e81d7e8b34450481e143a208b2/llvm/tools/dsymutil/DwarfLinkerForBinary.cpp#L407-L421

Closes #13165.

PiperOrigin-RevId: 366215825
  • Loading branch information
keith authored and copybara-github committed Apr 1, 2021
1 parent 0299cd7 commit 47edc57
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions tools/osx/crosstool/wrapped_clang.cc
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,13 @@ int main(int argc, char *argv[]) {
return 0;
}

std::vector<std::string> dsymutil_args = {
"/usr/bin/xcrun", "dsymutil", linked_binary, "-o", dsym_path, "--flat"};
std::vector<std::string> dsymutil_args = {"/usr/bin/xcrun",
"dsymutil",
linked_binary,
"-o",
dsym_path,
"--flat",
"--no-swiftmodule-timestamp"};
RunSubProcess(dsymutil_args);
return 0;
}

0 comments on commit 47edc57

Please sign in to comment.