move rules_pkg out of Bazel #8857

aiuto · 2019-07-10T22:15:49Z

//tools/build_defs/pkg:{pkg_deb, pkg_rpm, pkg_tar} are being pulled out of Bazel core and moved to https://github.com/bazelbuild/rules_pkg/tree/master/pkg. Users should migrate to the new versions.

Migration:

Add WORKSPACE stanza as specified in a rule_pkg release
https://github.com/bazelbuild/rules_pkg/releases

Replace instances of

load("//tools/build_defs/pkg:pkg.bzl", "pkg_tar", "pkg_deb")
load("//tools/build_defs/pkg:rpm.bzl", "pkg_rpm")

with

load("@rules_pkg//:pkg.bzl", "pkg_tar", "pkg_deb")
load("@rules_pkg//:rpm.bzl", "pkg_rpm")

One line solution (for some users)

find . -name 'BUILD' -o -name '*.bzl' | xargs sed -i -e '/^load/s#//tools/build_defs/pkg:#@rules_pkg//:#'

Expected timeline:

The bazelbuild/rules_pkg repository is available for use now. Issues against packaging rules are being transferred to that repository and will be addressed there.
Flag to be released in Bazel 0.29.
Enabled by default in next Bazel incompatible flag flip release after 0.29
//tools/build_defs/pkg/... removed from Bazel by EOY 2019

The text was updated successfully, but these errors were encountered:

This flag turns off the rules //tools/build_defs/pkg:{pkg_deb, pkg_rpm, pkg_tar}. The code has moved to https://github.com/bazelbuild/rules_pkg/tree/master/pkg. Users should migrate to the new versions. RELNOTES: Adds flag --//tools/build_defs/pkg:incompatible_no_build_defs_pkg. This flag turns off the rules //tools/build_defs/pkg:{pkg_deb, pkg_rpm, pkg_tar}. Part of #8857 Closes #8858. PiperOrigin-RevId: 258574031

See #8857 Thoughts: - The change to discard_graph_edges_test.sh is ridiculous. The test is flaky in CI and super brittle. - The fact that some integration tests rely on a WORKSPACE that matches that used to build bazel is odd. I should be able to use the built version of Bazel with my own workspace, with rules_cc and rules_pkg at a different revision level. We should have an integration test framework which establishes an entirely different WORKSPACE and runs a variety of tests within that, rather than trying to build a special purpose one for each test. RELNOTES: None PiperOrigin-RevId: 260074256

dslomov · 2019-08-05T13:09:54Z

Will the migration tooling be available to do this change?

…o load("@rules_pkg//:...", ...) See: bazelbuild/bazel#8857

aiuto · 2019-08-09T19:16:00Z

Will the migration tooling be available to do this change?

I could do special purpose tooling with a small python script. OR.. I could wait for a migration tool that can update WORKSPACE IFF any of the BUILD or bzl files were transformed.

The other thing we can do is not bother flipping now and get people to migrate by only adding new features to the new repo.

aiuto · 2020-12-23T17:53:24Z

No one should be using @bazel_tools/rules_pkg any more. They should use github.com/bazelbuild/rules_pkg.
I think we can fix this by removing the migration labels and/or changing the title of this. I'll do both.
That said, it is just going to disappear from Bazel at one point, with no migration warning.

aiuto · 2021-01-22T01:39:38Z

Status update
github.com/bazelbuild/rules_pkg now has .deb packaging working on linux, macos and Windows.
I plan to remove pkg_deb from Bazel around March 2021.

No timeline for pkg_tar removal.

*** Reason for rollback *** While this worked at the time. Upgrading rules_pkg to current versions requires adding rules_python to the test WORKSPACE. This makes the complexity worse. I'm falling back to a different solution where bazel builds in a mini-tar that is sufficient for these tests but is not tempting for users to use. *** Original change description *** Switch Android rules runtime deps builder to use rules_pkg for pkg_tar. See #8857 Thoughts: - The change to discard_graph_edges_test.sh is ridiculous. The test is flaky in CI and super brittle. - The fact that some integration tests rely on a WORKSPACE that matches that used to build bazel is odd. I should be able to use the built version of Bazel with my own workspace, with rules_cc and rules_pkg at a different revision level. We should have an integr... *** RELNOTES: None PiperOrigin-RevId: 358382248

#8857 Fixes #11217 (#11217) RELNOTES: pkg_deb is no longer part of @bazel_tools//build_defs/pkg:pkg.bzl. Use https://github.com/bazelbuild/rules_pkg/tree/main/pkg instead PiperOrigin-RevId: 360464481

Needed to unblock #8857 Closes #11270. PiperOrigin-RevId: 366994484

aiuto · 2021-04-14T20:05:37Z

Closing this out.

rules_pkg exists
an internal pkg_tar exists in Bazel, but it will receive no more fixes. Provide a tiny tar utility for use in tests #11183 exists to track making that inaccessible.

No one should be using this any more. See: bazelbuild#8857

No one should be using this any more. See: #8857 Closes #14934. PiperOrigin-RevId: 432147816

janpfeifer · 2022-12-24T09:08:54Z

For pkg_tar use instead:

load("@rules_pkg//pkg:tar.bzl", "pkg_tar")

sspathare97 · 2023-03-23T21:38:39Z

For pkg_tar use instead:

load("@rules_pkg//pkg:tar.bzl", "pkg_tar")

Aren't they the same thing? pkg:pkg.bzl and pkg:tar.bzl

aiuto · 2023-03-24T00:14:00Z

No. They are different files. pkg.bzl is going to disappear shortly and you must use pkg/tar.bzl.

These rules have been extracted from the Bazel sources and are now available at bazelbuild/rules_pkg. See the following issue for more details: bazelbuild/bazel#8857 Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

hese rules have been extracted from the Bazel sources and are now available at bazelbuild/rules_pkg. See the following issue for more details: bazelbuild/bazel#8857 Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

These rules have been extracted from the Bazel sources and are now available at bazelbuild/rules_pkg. See the following issue for more details: bazelbuild/bazel#8857 Signed-off-by: Lee Yarwood <lyarwood@redhat.com>

aiuto added the incompatible-change Incompatible/breaking change label Jul 10, 2019

aiuto added this to the rules_package milestone Jul 10, 2019

aiuto self-assigned this Jul 10, 2019

aiuto added P2 We'll consider working on this in future. (Assignee optional) team-Rules-Server Issues for serverside rules included with Bazel labels Jul 10, 2019

aiuto mentioned this issue Jul 10, 2019

Add --//tools/build_defs/pkg:incompatible_no_build_defs_pkg flag #8858

Closed

aiuto added the migration-ready label Jul 10, 2019

aiuto added bazel 1.0 and removed P2 We'll consider working on this in future. (Assignee optional) labels Jul 19, 2019

dslomov added untriaged and removed untriaged labels Jul 24, 2019

lberki added P1 I'll work on this now. (Assignee required) and removed untriaged labels Jul 25, 2019

katre added migration-0.29 and removed migration-ready labels Aug 2, 2019

aiuto added a commit to aiuto/buildtools that referenced this issue Aug 7, 2019

Add rewrite for load("@bazel_tools//tools/build_defs/pkg:...", ...) t…

184f020

…o load("@rules_pkg//:...", ...) See: bazelbuild/bazel#8857

aiuto mentioned this issue Aug 7, 2019

WIP: Add rewrite for @bazel_tools//tools/build_defs/pkg to @rules_pkg bazelbuild/buildtools#693

Closed

jmillikin mentioned this issue Aug 8, 2019

Please add context action for creating archives (tar, zip, maybe jar?) #3768

Closed

dslomov changed the title ~~//tools/build_defs/pkg:incompatible_no_build_defs_pkg flag~~ //tools/build_defs/pkg:incompatible_no_build_defs_pkg: move rules_pkg out of Bazel Aug 9, 2019

dslomov added breaking-change-2.0 and removed bazel 1.0 labels Aug 20, 2019

aiuto mentioned this issue Sep 9, 2019

Use @rules_pkg for pkg_tar bazelbuild/bazel-website#204

Merged

dslomov added the migration-1.0 label Oct 10, 2019

aiuto removed migration-3.7 labels Dec 23, 2020

aiuto changed the title ~~//tools/build_defs/pkg:incompatible_no_build_defs_pkg: move rules_pkg out of Bazel~~ move rules_pkg out of Bazel - //tools/build_defs/pkg:incompatible_no_build_defs_pkg Dec 23, 2020

aiuto changed the title ~~move rules_pkg out of Bazel - //tools/build_defs/pkg:incompatible_no_build_defs_pkg~~ move rules_pkg out of Bazel Jan 22, 2021

bazel-io pushed a commit that referenced this issue Apr 6, 2021

update pkg_tar to 0.3.x

99079b3

Needed to unblock #8857 Closes #11270. PiperOrigin-RevId: 366994484

aiuto closed this as completed Apr 14, 2021

steple mentioned this issue Feb 14, 2022

Packaging rules: Remove documentation for pkg_tar #14797

Closed

aiuto added a commit to aiuto/bazel that referenced this issue Mar 2, 2022

Drop docs for tools/build_defs/pkg.

f1176e7

No one should be using this any more. See: bazelbuild#8857

aiuto mentioned this issue Mar 2, 2022

Drop docs for tools/build_defs/pkg. #14934

Closed

bazel-io pushed a commit that referenced this issue Mar 3, 2022

Drop docs for tools/build_defs/pkg.

efe8f3c

No one should be using this any more. See: #8857 Closes #14934. PiperOrigin-RevId: 432147816

janpfeifer mentioned this issue Dec 24, 2022

How does one use pkg_tar in WORKSPACE/BUILD rules after Bazel 6 upgrade ? bazelbuild/rules_pkg#655

Closed

prestonvanloon mentioned this issue Mar 13, 2023

Replace @bazel pkg_tar rule with canonical @rules_pkg pkg_tar prysmaticlabs/prysm#12120

Merged

lyarwood mentioned this issue Jul 28, 2023

bazel: Move to rules_pkg extracted version of pkg_tar kubevirt/kubevirt#10189

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move rules_pkg out of Bazel #8857

move rules_pkg out of Bazel #8857

aiuto commented Jul 10, 2019 •

edited

Loading

dslomov commented Aug 5, 2019

aiuto commented Aug 9, 2019

aiuto commented Dec 23, 2020

aiuto commented Jan 22, 2021

aiuto commented Apr 14, 2021

janpfeifer commented Dec 24, 2022

sspathare97 commented Mar 23, 2023

aiuto commented Mar 24, 2023

move rules_pkg out of Bazel #8857

move rules_pkg out of Bazel #8857

Comments

aiuto commented Jul 10, 2019 • edited Loading

dslomov commented Aug 5, 2019

aiuto commented Aug 9, 2019

aiuto commented Dec 23, 2020

aiuto commented Jan 22, 2021

aiuto commented Apr 14, 2021

janpfeifer commented Dec 24, 2022

sspathare97 commented Mar 23, 2023

aiuto commented Mar 24, 2023

aiuto commented Jul 10, 2019 •

edited

Loading