-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Automated rollback of changelist 260074256.
*** Reason for rollback *** While this worked at the time. Upgrading rules_pkg to current versions requires adding rules_python to the test WORKSPACE. This makes the complexity worse. I'm falling back to a different solution where bazel builds in a mini-tar that is sufficient for these tests but is not tempting for users to use. *** Original change description *** Switch Android rules runtime deps builder to use rules_pkg for pkg_tar. See #8857 Thoughts: - The change to discard_graph_edges_test.sh is ridiculous. The test is flaky in CI and super brittle. - The fact that some integration tests rely on a WORKSPACE that matches that used to build bazel is odd. I should be able to use the built version of Bazel with my own workspace, with rules_cc and rules_pkg at a different revision level. We should have an integr... *** RELNOTES: None PiperOrigin-RevId: 358382248
- Loading branch information
1 parent
10b3479
commit 5a8a924
Showing
3 changed files
with
3 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters