-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aapt2 + mobile-install v1 doesn't build a runnable APK #5799
Comments
Reproduced:
|
@sunyal I can reproduce this with |
@jin if I recall it was through |
@jin does it work if you call |
@jin I was able to install it and run it using the |
@sunyal thanks for confirming! It's definitely an issue with mobile-install. |
Hey @sunyal, the For now, the workaround to use aapt2 would be to use |
@jin thanks for the update
…On Mon, Aug 13, 2018 at 3:19 PM Jingwen ***@***.***> wrote:
Hey @sunyal <https://github.com/sunyal>, the mobile-install built in
Bazel is actually v1 of the command. There is mobile-install v2, a
rewrite of v1, due to be open sourced this quarter. That version is more
feature packed and works with aapt2. Since v2 will be replacing v1, I'm
downgrading this to P3 as v1 will eventually go away.
For now, the workaround to use aapt2 would be to use bazel build and adb
install. Sorry for the inconvenience.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5799 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AERrAjoQOGpbq__l60i9Fev7Tc40pRPNks5uQdEqgaJpZM4VzP1F>
.
|
@sunyal this is fixed, and will be available in 0.22 (or head now) |
Previously, the resource apk was always built with aapt regardless of configuration. This threads the aapt version into the resource processing action builder. Fixes: bazelbuild/bazel#5799 Ref: bazelbuild/bazel#6814 RELNOTES: mobile-install now works with aapt2. Try it out with `bazel mobile-install --android_aapt=aapt2 //my:target` PiperOrigin-RevId: 224566567
Bug report from @sunyal:
Building the example app from Bazel Android Tutorial with
--android_aapt=aapt2
results in a un-runnable app. App is fine with--android_aapt=aapt
.The text was updated successfully, but these errors were encountered: