Update toolchains support for latest rules_apple and transitions #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/update-toolchains
branch
2 times, most recently
from
00f0c42
to
917bd6b
Compare
jszumski
approved these changes
Mar 7, 2024
luispadron
added a commit
that referenced
this pull request
Mar 7, 2024
luispadron
force-pushed
the
luis/update-toolchains
branch
from
917bd6b
to
3f3b30b
Compare
luispadron
force-pushed
the
luis/update-toolchains
branch
from
3f3b30b
to
f27577c
Compare
thiagohmcruz
approved these changes
Mar 8, 2024
This was referenced Mar 11, 2024
luispadron
added a commit
that referenced
this pull request
Apr 18, 2024
In Bazel 7+ `ObjcProvider` no longer supports/provides the required linking attributes. The migrations is detailed here: bazelbuild/bazel#16939. In summary, as part of the migration, the `ObjcProvider` fields which previously provided linking related information are now now longer providing that info. In addition to this, a new flag: `--incompatible_objc_linking_info_migration` was added to further delete these link attrs from the `ObjcProvider` making it an error if the attr is used or set. The goal of this PR is to address support for `ObjcProvider` migration and to instead use the correct linking information from `CcInfo`. This will support both Bazel 6/7+. It does not try to support `--incompatible_objc_linking_info_migration` as that requires more changes and should be a separate PR Depends on: - #848 - #847
luispadron
added a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares our mac and xplat toolchains for Bazel 7
Changes:
"@bazel_tools//tools/cpp:current_cc_toolchain"with"@build_bazel_rules_apple//apple:default_cc_toolchain_forwarder"_toolchainto_mac_toolchain, this matches rules_apple and better represents that the toolchain is for the host platformcfg = "exec"to the mac and xplat toolchainsexecis correct here. This is the same cfg they use in rules_apple