Update transition support #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
commented
Mar 6, 2024
luispadron
commented
Mar 6, 2024
luispadron
force-pushed
the
luis/update-transition_support
branch
4 times, most recently
from
5121b02
to
d139eae
Compare
|
With this change + some toolchain updates i have in a follow up i got a target in our project to pass the build using Bazel 7 |
luispadron
added a commit
that referenced
this pull request
Mar 7, 2024
luispadron
force-pushed
the
luis/update-transition_support
branch
2 times, most recently
from
ecdfc8d
to
3095a38
Compare
luispadron
force-pushed
the
luis/update-toolchains
branch
from
3f3b30b
to
f27577c
Compare
luispadron
force-pushed
the
luis/update-transition_support
branch
from
3095a38
to
044972f
Compare
mattrobmattrob
approved these changes
Mar 7, 2024
thiagohmcruz
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
LGTM, agree that ideally we should get rid of the custom rules_ios stuff and simply import/use what exists upstream. Should we file an issue for that if it doesn't exist already?
ps: edited your PR description to link to rules_apple in a specific SHA instead of master for future reference.
This was referenced Mar 11, 2024
luispadron
force-pushed
the
luis/update-transition_support
branch
from
044972f
to
172d66a
Compare
luispadron
added a commit
that referenced
this pull request
Mar 28, 2024
Re-add some code i had deleted in #847, this logic was depended on by some of our users. Eventually we should unify the transition support around rules_apple / use that outright.
leonidmelnyk
pushed a commit
to leonidmelnyk/rules_ios
that referenced
this pull request
Apr 5, 2024
This reverts commit 144eb18.
acecilia
pushed a commit
to revolut-mobile/rules_ios
that referenced
this pull request
Apr 5, 2024
…d libs to CcInfo linking context in Bazel 7 (#3) * Revert "Add force load libs to CcInfo linking context in Bazel 7 (#2)" This reverts commit fb395f9. * Revert "Re-add ios_multi_cpus transition setting from rules_ios (bazel-ios#856)" This reverts commit 6d6e051. * Revert "Safer objc_provider assignment in apple_framework_packaging (bazel-ios#855)" This reverts commit 30733da. * Revert "Forward package_name to swift_library part of apple_library (bazel-ios#853)" This reverts commit 3b0ca4c. * Revert "Allow consumers to set always_include_developer_search_paths in swift_library (bazel-ios#852)" This reverts commit da630a2. * Revert "Update transition support (bazel-ios#847)" This reverts commit 144eb18. * PMNG-7009 [platform] Add force load libs to CcInfo linking context in Bazel 7 --------- Co-authored-by: Leonid Melnyk <leonid.melnyk@revolut.com>
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_ios
that referenced
this pull request
Apr 16, 2024
This reverts commit 144eb18.
acecilia
pushed a commit
to revolut-mobile/rules_ios
that referenced
this pull request
Apr 16, 2024
This reverts commit 144eb18.
luispadron
added a commit
that referenced
this pull request
Apr 18, 2024
In Bazel 7+ `ObjcProvider` no longer supports/provides the required linking attributes. The migrations is detailed here: bazelbuild/bazel#16939. In summary, as part of the migration, the `ObjcProvider` fields which previously provided linking related information are now now longer providing that info. In addition to this, a new flag: `--incompatible_objc_linking_info_migration` was added to further delete these link attrs from the `ObjcProvider` making it an error if the attr is used or set. The goal of this PR is to address support for `ObjcProvider` migration and to instead use the correct linking information from `CcInfo`. This will support both Bazel 6/7+. It does not try to support `--incompatible_objc_linking_info_migration` as that requires more changes and should be a separate PR Depends on: - #848 - #847
luispadron
added a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely updates the
transition_support.bzlfile. It now essentially is a copy of the one in here: https://github.com/bazelbuild/rules_apple/blob/f37305163dd7546f87839f3187e153c955cd20d8/apple/internal/transition_support.bzlThis is important as Bazel 7 has changed this a lot.
Changes:
PATCH:comments)