Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jasmine): user templated_args should be passed to jasmine after 3 internal templated_args #1743

Merged
merged 1 commit into from
Mar 27, 2020
Merged

fix(jasmine): user templated_args should be passed to jasmine after 3 internal templated_args #1743

merged 1 commit into from
Mar 27, 2020

Conversation

gregmagolan
Copy link
Collaborator

No description provided.

@gregmagolan gregmagolan force-pushed the fix_jasmine_node_test_templated_args branch from aceab0d to 0efa856 Compare March 27, 2020 00:11
@gregmagolan gregmagolan force-pushed the fix_jasmine_node_test_templated_args branch from 0efa856 to 30d586b Compare March 27, 2020 00:20
alexeagle
alexeagle approved these changes Mar 27, 2020
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that was a bug... 🐛

@alexeagle alexeagle merged commit baa68c1 into bazel-contrib:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@soldair soldair Awaiting requested review from soldair

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregmagolan @alexeagle @googlebot