fix(jasmine): user templated_args should be passed to jasmine after 3…

… internal templated_args

packages/jasmine/src/jasmine_node_test.bzl

@@ -74,8 +74,7 @@ def jasmine_node_test(
     all_data += [":%s_devmode_srcs.MF" % name]
     all_data += [Label("@bazel_tools//tools/bash/runfiles")]
 
-    # If the target specified templated_args, pass it through.
-    templated_args = kwargs.pop("templated_args", [])
+    templated_args = []
     templated_args.append("$(location :%s_devmode_srcs.MF)" % name)
 
     if coverage:
@@ -91,6 +90,11 @@ def jasmine_node_test(
     else:
         templated_args.append("--noconfig")
 
+    # jasmine_runner.js consumes the first 3 args provided above.
+    # The remaining target templated_args will be passed through to jasmine or
+    # specs to consume.
+    templated_args.extend(kwargs.pop("templated_args", []))
+
     nodejs_test(
         name = name,
         data = all_data,

packages/jasmine/test/BUILD.bazel

@@ -97,7 +97,12 @@ jasmine_node_test(
         "dynamic_import.js",
     ],
     args = [
+        # the --node_options arg will be consumed by the node launcher
         "--node_options=--experimental-modules",
+        # the remaining args should be passed to the spec
+        "arg1",
+        "arg2",
+        "arg3",
     ],
 )
 
@@ -107,8 +112,16 @@ jasmine_node_test(
         "args_test.js",
         "dynamic_import.js",
     ],
+    args = [
+        # args should be passed after templated_args
+        "arg3",
+    ],
     templated_args = [
+        # the --node_options templated arg will be consumed by the node launcher
         "--node_options=--experimental-modules",
+        # the remaining args should be passed to the spec
+        "arg1",
+        "arg2",
     ],
 )
 

packages/jasmine/test/args_test.js

@@ -1,5 +1,11 @@
 describe('args', () => {
-  it('should pass through templated_args', async () => {
+  it('should pass through other templated_args', async () => {
+    // args that are not consumed by the node launcher should be passed through
+    // to the spec
+    expect(process.argv.slice(2)).toEqual(['arg1', 'arg2', 'arg3']);
+  });
+
+  it('should apply --node_options in templated_args', async () => {
     // without --node_options=--experimental-modules this will fail
     const dynamicImport = await import('./dynamic_import.js');
     dynamicImport.default.hello();