Fix runtimeconfig for AspNetCore projects #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What? Adds a a new `project_sdk` attribute to all targets that defaults to `default` The attribute can also be set to `web` which indicates that the Web sdk is being targeted and thus the runtimeconfig will include the AspNetCore framework in the `includedFrameworks/frameworks` key of the config. ## Why? This is required to make the binary targets runnable. At some point I hope to simplify this so that the correct NuGet packages are implicitly added to the targets without having to declare them in `private_deps` or `runtime_packs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a a new
project_sdkattribute to all targets that defaults todefaultThe attribute can also be set towebwhich indicates that the Web sdk is being targeted and thus the runtimeconfig will include the AspNetCore framework in theincludedFrameworks/frameworkskey of the config.Why?
This is required to make the binary targets runnable. At some point I hope to simplify this so that the correct NuGet packages are implicitly added to the targets without having to declare them in
private_depsorruntime_packs.