Skip to content

Commit

Permalink
Fix runtimeconfig for AspNetCore projects (#323)
Browse files Browse the repository at this point in the history
* Fix runtimeconfig for AspNetCore projects

## What?
Adds a a new `project_sdk` attribute to all targets that defaults to `default`
The attribute can also be set to `web` which indicates that the Web sdk is being targeted
and thus the runtimeconfig will include the AspNetCore framework in the `includedFrameworks/frameworks` key of the config.

## Why?
This is required to make the binary targets runnable. At some point I hope to simplify this so that
the correct NuGet packages are implicitly added to the targets without having to declare them in
`private_deps` or `runtime_packs`.
  • Loading branch information
purkhusid authored Jan 3, 2023
1 parent 676afa7 commit 2d057b3
Show file tree
Hide file tree
Showing 23 changed files with 74 additions and 36 deletions.
8 changes: 5 additions & 3 deletions docs/csharp_binary.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions docs/csharp_library.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions docs/csharp_nunit_test.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions docs/csharp_test.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2d057b3

Please sign in to comment.