Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a compatibility issue with Capacitor 2.2.0 where Config does not contain any static methods #83

Closed
wants to merge 2 commits into from
Closed

Fixed a compatibility issue with Capacitor 2.2.0 where Config does not contain any static methods #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0761c98
Update CapacitorFirebaseAuth.java
tchvu3 Jun 12, 2020
1429162
Update GoogleProviderHandler.java
tchvu3 Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ebase-auth/src/main/java/com/baumblatt/capacitor/firebase/auth/CapacitorFirebaseAuth.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ public void load() {

getConfigValue("nada");

String[] providers = Config.getArray(CONFIG_KEY_PREFIX+"providers", new String[0]);
this.nativeAuth = Config.getBoolean(CONFIG_KEY_PREFIX+"nativeAuth", false);
String languageCode = Config.getString(CONFIG_KEY_PREFIX+"languageCode", "en");
String[] providers = getBridge().getConfig().getArray(CONFIG_KEY_PREFIX+"providers", new String[0]);
this.nativeAuth = getBridge().getConfig().getBoolean(CONFIG_KEY_PREFIX+"nativeAuth", false);
String languageCode = getBridge().getConfig().getString(CONFIG_KEY_PREFIX+"languageCode", "en");

// FirebaseApp is not initialized in this process - Error #1
Log.d(PLUGIN_TAG, "Verifying if the default FirebaseApp was initialized.");
Expand Down
2 changes: 1 addition & 1 deletion ...h/src/main/java/com/baumblatt/capacitor/firebase/auth/handlers/GoogleProviderHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class GoogleProviderHandler implements ProviderHandler, GoogleApiClient.O
public void init(CapacitorFirebaseAuth plugin) {
this.plugin = plugin;

String[] permissions = Config.getArray(CONFIG_KEY_PREFIX + "permissions.google", new String[0]);
String[] permissions = plugin.getBridge().getConfig().getArray(CONFIG_KEY_PREFIX + "permissions.google", new String[0]);

GoogleApiAvailability googleAPI = GoogleApiAvailability.getInstance();
int result = googleAPI.isGooglePlayServicesAvailable(this.plugin.getContext());
Expand Down