-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a compatibility issue with Capacitor 2.2.0 where Config does not contain any static methods #83
Conversation
Compatible with Capacitor 2.2.0
Compatible with Capacitor 2.2.0
This fixes it. |
We have put the static Config back (ionic-team/capacitor#3126), but please, if you notice that we break something in a patch or minor release, report it in Capacitor repo. Anyway, the change in this PR is still recommended as the static Config is now deprecated and will go away in a future 3.0.0 release. |
there are some changes introduced in version 2.2.0. I am guessing this is where the conflicts are coming from |
Hi Avihu, I think that this problem is already solved by another PR, but thank you anyway. If I'm wrong, be encouraged to fix the conflicts and send the PR again. Best regards, |
I am using the latest Capacitor(2.3.x) wiith 2.3.1 .. Android Studio complains (No CapConfig)
|
yep same issue :/ |
@gggiiia @curiouscod3 I have the exact same issue. Have you found a fix? EDIT: Fixed with |
Hi @tchvu3 , We still need this PR? Can you please, revisit. Please resolve the conflicts or close this PR. Best regards, |
hey there. |
You can view the change in the change log:
https://github.com/ionic-team/capacitor/blob/master/CHANGELOG.md#220-2020-06-10
specifically:
"feat(android): move Config to be per-instance rather than a singleton (#3055) (b4815a5), closes #3055"