Faster pollution #343
Merged
Faster pollution #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| LocalPollutionEffect pE = localPollutions.get(robotID); | ||
| for (MapLocation affectedLoc : getAllLocationsWithinRadiusSquared(pE.loc, pE.radiusSquared)) { | ||
| this.localAdditivePollution[locationToIndex(affectedLoc)] -= pE.additiveEffect; | ||
| this.localMultiplicativePollution[locationToIndex(affectedLoc)] /= pE.multiplicativeEffect; |
There was a problem hiding this comment.
anything preventing this from divide by 0?
There was a problem hiding this comment.
yeah, the multiplicative effect is always either 0.8 or 1.
arvid220u
force-pushed
the
fasterpollution
branch
from
d087929
to
8b44332
Compare
|
In fact, when running this in the client, I am not noticing a speedup when removing the pollution calculation, indicating that that is not what makes the client slow. Since it will be a pain to update the schema and ensure backwards compatibility, I suggest we just don't do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #342.
actualPollutionThe first change is dramatic — a game that used to take more than 1 hour now takes 3 minutes.