Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance of pollution code is subpar #342

Closed
arvid220u opened this issue Jan 16, 2020 · 2 comments · Fixed by #343
Closed

Performance of pollution code is subpar #342

arvid220u opened this issue Jan 16, 2020 · 2 comments · Fixed by #343
Labels
client Related to visualizer or client critical engine Related to engine (or schema). schema

Comments

@arvid220u
Copy link
Contributor

"There's no chance this will be the bottleneck" — well, turns out it is.

Engine should be easy to update, and have the biggest impact (since it happens on a per-turn basis).

To update client this requires a schema change, which might not be worth it (it will turn a 6464num_vaporators loop into a 64*64 loop, so it really only matters if we have a lot of vaporators).

@arvid220u arvid220u added engine Related to engine (or schema). client Related to visualizer or client critical schema labels Jan 16, 2020
@arvid220u arvid220u mentioned this issue Jan 16, 2020
3 tasks
@Diuven
Copy link
Contributor

Diuven commented Jan 16, 2020

Is the performance issue because of updating pollution values themselves or calculating pollutions' effect on robots?

@arvid220u
Copy link
Contributor Author

updating the pollution values

j-mao added a commit that referenced this issue Jan 20, 2020
Decrease game runtime limit since #342 fixed.
Add logging for #341.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to visualizer or client critical engine Related to engine (or schema). schema
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants