Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dialyzer and xref warnings #94

Merged
merged 10 commits into from
May 30, 2014
Merged

Commits on May 29, 2014

  1. Configuration menu
    Copy the full SHA
    6a99523 View commit details
    Browse the repository at this point in the history
  2. Ignore warning from commit hooks.

    Protobuffs generates insufficient type information for its records.
    
    Resolves:
    
    riak_pb_codec.erl:338: Invalid type specification for function riak_pb_codec:decode_commit_hooks/1. The success typing is ([any()]) -> [{atom(),atom() | [any(),...]} | {'modfun',atom(),atom() | [any(),...]}]
    seancribbs committed May 29, 2014
    Configuration menu
    Copy the full SHA
    14df6be View commit details
    Browse the repository at this point in the history
  3. Ignore warning from lists:keyfind/3 returning only false.

    Calls within riak_pb only pass empty lists in place of
    type_mappings(), but riak_kv will pass its own ?MOD_MAP. This results
    in a false warning in encode_type/2.
    
    Resolves:
    
    riak_pb_dt_codec.erl:181: The pattern {AtomType, _} can never match the type 'false'
    seancribbs committed May 29, 2014
    Configuration menu
    Copy the full SHA
    4afc507 View commit details
    Browse the repository at this point in the history
  4. RpbPair fields are both binaries.

    Resolves:
    
    riak_pb_search_codec.erl:45: Invalid type specification for function riak_pb_search_codec:decode_search_doc/1. The success typing is (#rpbsearchdoc{fields::[{_,_,_}]}) -> [{[any()],[any()]}]
    seancribbs committed May 29, 2014
    Configuration menu
    Copy the full SHA
    0f193da View commit details
    Browse the repository at this point in the history
  5. We don't have access to riakc_obj from riak_pb, so use the plain types.

    Resolves:
    
    Unknown types:
      riakc_obj:metadata/0
      riakc_obj:value/0
    seancribbs committed May 29, 2014
    Configuration menu
    Copy the full SHA
    75043b0 View commit details
    Browse the repository at this point in the history
  6. Turn off exports_not_used xref check.

    This is a library application, so all the exported functions in
    generated code are potentially used elsewhere.
    seancribbs committed May 29, 2014
    Configuration menu
    Copy the full SHA
    b4b5404 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3523b14 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    babb1ba View commit details
    Browse the repository at this point in the history

Commits on May 30, 2014

  1. Configuration menu
    Copy the full SHA
    dfdcf34 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d10c567 View commit details
    Browse the repository at this point in the history