Fix dialyzer and xref warnings #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protobuffs generates insufficient type information for its records.
Resolves:
riak_pb_codec.erl:338: Invalid type specification for function riak_pb_codec:decode_commit_hooks/1. The success typing is ([any()]) -> [{atom(),atom() | [any(),...]} | {'modfun',atom(),atom() | [any(),...]}]
Calls within riak_pb only pass empty lists in place of
type_mappings(), but riak_kv will pass its own ?MOD_MAP. This results
in a false warning in encode_type/2.
Resolves:
riak_pb_dt_codec.erl:181: The pattern {AtomType, _} can never match the type 'false'
Resolves:
riak_pb_search_codec.erl:45: Invalid type specification for function riak_pb_search_codec:decode_search_doc/1. The success typing is (#rpbsearchdoc{fields::[{_,_,_}]}) -> [{[any()],[any()]}]
Resolves: Unknown types: riakc_obj:metadata/0 riakc_obj:value/0
This is a library application, so all the exported functions in generated code are potentially used elsewhere.
seancribbs
added a commit
to basho/tools.mk
that referenced
this pull request
May 30, 2014
As found in basho/riak_pb#94, on FreeBSD 9, the "\s" shortcut character class leads to not filtering out the desired lines, meaning we were left with a non-empty dialyzer_unhandled_warnings, even if all known warnings were filtered by the second grep. Changing this to [[:space:]] resolves the issue, and is more consistent with the previous 'grep' call in the step.
|
+1 |
|
Ready to be put on bors once this is merged? |
|
Yes to bors. |
seancribbs
added a commit
that referenced
this pull request
May 30, 2014
Fix dialyzer and xref warnings
|
Added to bors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's get this build SUPER GREEN