Maven will autogenerate RiakMessageCodes #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2014 02:35
Uses a template and generates com.basho.riak.protobuf.RiakMessageCodes which will now be packaged along with the protobufs
|
|
||
| } | ||
|
|
||
| result.put("packageName", "com.basho.riak.protobuf"); |
There was a problem hiding this comment.
do you think it's worth adding a "This file was generated etc" comment in the generated source?
|
+1, although, although I'm sure @mgodave should review too. |
|
Yay! 💃 |
|
I can't get this to build. Looking into it further... [ERROR] Failed to execute goal com.webguys:string-template-maven-plugin:1.1:render (default) on project riak-pb: Execution default of goal com.webguys:string-template-maven-plugin:1.1:render failed: An API incompatibility was encountered while executing com.webguys:string-template-maven-plugin:1.1:render: java.lang.NoSuchMethodError: org.apache.maven.execution.MavenSession.getRepositorySession()Lorg/sonatype/aether/RepositorySystemSession; |
|
It's a maven incompatibility issue |
|
There is a conflict between the the plugin and maven 3.1 |
|
verified that I get the same error w/ |
|
So, we're good with "We need to use maven 3.0.x right now, but we'll submit a patch to the plug-in repo" ? |
|
Yeah, logged #83 to track it. |
|
👍 |
broach
pushed a commit
that referenced
this pull request
Feb 28, 2014
Maven will autogenerate RiakMessageCodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a template and generates com.basho.riak.protobuf.RiakMessageCodes
which will now be packaged along with the protobufs
To verify, run:
mvn clean installthen inspecttarget/generated-sources/protobuf/com/basho/riak/protobuf/RiakMessageCodes.javaas well as check the jar:jar tvf target/riak-pb-2.0.0.12-SNAPSHOT.jar |grep MessageCod