Where is RpbGetServerInfoReq defined?

[xpe]

I'm pretty new to protocol buffers. This is what I see in riak.proto:

// Get server info request - no message defined,
// just send RpbGetServerInfoReq message code
message RpbGetServerInfoResp {
    optional bytes node = 1;
    optional bytes server_version = 2;
}

Where is RpbGetServerInfoReq defined?

[xpe]

Ok, I looked in the Java client and found this in RiakMessageCodes.java:

interface RiakMessageCodes {
  public static final int MSG_ErrorResp = 0;
  public static final int MSG_PingReq = 1;
  public static final int MSG_PingResp = 2;
  public static final int MSG_GetClientIdReq = 3;
  public static final int MSG_GetClientIdResp = 4;
  public static final int MSG_SetClientIdReq = 5;
  public static final int MSG_SetClientIdResp = 6;
  public static final int MSG_GetServerInfoReq = 7;
  public static final int MSG_GetServerInfoResp = 8;
  // ...
}

[xpe]

Why not define these codes in this repository? They are defined for Erlang, so why not Java?

%% @doc Converts a symbolic message name into a message code. Replaces
%% `riakc_pb:msg_code/1'.
-spec msg_code(atom()) -> integer().
msg_code(rpberrorresp)           -> 0;
msg_code(rpbpingreq)             -> 1;
msg_code(rpbpingresp)            -> 2;
msg_code(rpbgetclientidreq)      -> 3;
msg_code(rpbgetclientidresp)     -> 4;
msg_code(rpbsetclientidreq)      -> 5;
msg_code(rpbsetclientidresp)     -> 6;
msg_code(rpbgetserverinforeq)    -> 7;
msg_code(rpbgetserverinforesp)   -> 8;
msg_code(rpbgetreq)              -> 9;

[xpe]

I'm reopening so Basho might see my comment, above.

[evanmcc]

If you look in the readme the code is defined as 7. Since there are no fields, there's no point in defining a message structure.

[xpe]

@evanmcc: Hello. I'm aware of what you said, but it isn't directly tied to my suggestion.

My argument is this: Since the Riak messages codes are part of the Riak PB API, it would be best for them to be kept in this source code. I'd suggest creating constants for them in a Java file that becomes part of the Maven artifact and can be referred to. Otherwise, a Java/Clojure/Scala/Groovy client has to define them in their own. That's error prone, but that is the way it is now. It would be better to define the constants in one place. Here, in this repo.

One might make the argument that only Protocol Buffer files belong in this repo. Meh. This repo is (or should be) about anything that Basho can provide so that JVM languages can make API calls without duplicating things. That includes .proto files and message code constants.

Would you ask a developer to "go write you own .proto files"? Probably not. So why tell them to go write their own constants?

[seancribbs]

@xpe We have implemented code-generation for these in Erlang and Python already, using a CSV file in the repository. We do have plans to generate them for Java as well, which will be straightforward. Please do engage @broach and @mgodave on this.

[broach]

This has now been addressed, see #82

[xpe]

Thanks!