Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use binary_to_atom/2 instead of binary_to_existing_atom/2. #933

Merged
merged 1 commit into from
May 9, 2014
Merged

Use binary_to_atom/2 instead of binary_to_existing_atom/2. #933

merged 1 commit into from
May 9, 2014

Commits on May 9, 2014

  1. Use binary_to_atom/2 instead of binary_to_existing_atom/2. 

    There's a possibility that the riak_dt code that contains the set
operation atoms hasn't been loaded when
riak_kv_crdt_json:set_op_from_json/1 is invoked, meaning
binary_to_existing_atom/2 will raise a badarg. We are already checking
the incoming operation as a binary via a guard on the relevant
function clause, so it is safe to use binary_to_atom/2 instead.
    @seancribbs
    seancribbs committed May 9, 2014
    4 Configuration menu
    Copy the full SHA
    2bab35b View commit details
    Browse the repository at this point in the history