Use binary_to_atom/2 instead of binary_to_existing_atom/2. #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a possibility that the riak_dt code that contains the set operation atoms hasn't been loaded when riak_kv_crdt_json:set_op_from_json/1 is invoked, meaning binary_to_existing_atom/2 will raise a badarg. We are already checking the incoming operation as a binary via a guard on the relevant function clause, so it is safe to use binary_to_atom/2 instead.
|
+1 2bab35b Fixes the issue I found. |
borshop
added a commit
that referenced
this pull request
May 9, 2014
Use binary_to_atom/2 instead of binary_to_existing_atom/2. Reviewed-by: Vagabond
seancribbs
added a commit
that referenced
this pull request
May 9, 2014
Use binary_to_atom/2 instead of binary_to_existing_atom/2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a possibility that the riak_dt code that contains the set operation
atoms hasn't been loaded when riak_kv_crdt_json:set_op_from_json/1 is invoked,
meaning binary_to_existing_atom/2 will raise a badarg. We are already checking
the incoming operation as a binary via a guard on the relevant function
clause, so it is safe to use binary_to_atom/2 instead.