Support non-binary error-reasons in define_js/4 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
define_js/4 did not include a pattern to match against non-binary values in
the error tuple that can be a result of evaluating call_driver/4. This caused
case_clause run-time errors when the reason for the error was not a binary.
({error, timeout} for example).
|
👍 to merge, https://github.com/basho/erlang_js/blob/master/src/js_driver.erl#L198 is sufficient enough to trigger this condition. |
cmeiklejohn
added a commit
that referenced
this pull request
Aug 21, 2013
Support non-binary error-reasons in define_js/4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
define_js/4 did not include a pattern to match against non-binary values in
the error tuple that can be a result of evaluating call_driver/4. This caused
case_clause run-time errors when the reason for the error was not a binary.
({error, timeout} for example).