Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the Assets API #1653

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Simplify the Assets API #1653

merged 1 commit into from
Jul 6, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #1518

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Jul 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

Uploaded Betty for commit 0ec5d33. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra force-pushed the simplify-assets branch 2 times, most recently from 1966b80 to 5f41fca Compare July 6, 2024 10:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

Uploaded Betty for commit 5f41fca. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra marked this pull request as ready for review July 6, 2024 10:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

Uploaded Betty for commit 5ed958f. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra merged commit fa921af into 0.4.x Jul 6, 2024
9 checks passed
@bartfeenstra bartfeenstra deleted the simplify-assets branch July 6, 2024 11:05
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (22c032d) to head (5ed958f).
Report is 328 commits behind head on 0.4.x.

Additional details and impacted files 
@@           Coverage Diff           @@
##            0.4.x    #1653   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         205      205           
  Lines       19234    19162   -72     
  Branches     3602     3560   -42     
=======================================
- Hits        18456    18387   -69     
+ Misses        526      524    -2     
+ Partials      252      251    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase Assets API performance
1 participant
@bartfeenstra