Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Assets API performance #1518

Closed
bartfeenstra opened this issue May 24, 2024 · 0 comments · Fixed by #1653
Closed

Increase Assets API performance #1518

bartfeenstra opened this issue May 24, 2024 · 0 comments · Fixed by #1653
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code

Comments

@bartfeenstra
Copy link
Owner

bartfeenstra commented May 24, 2024

  • Benchmark everything!
  • Consider renaming the file system API to the assets API
  • Consider removing functionality not needed for assets management (what exactly?)
  • Consider scanning for all files upon first use and then caching the resolved results, e.g. removing overridden files from the resulting file list.
  • FileSystem.open() should only take a single path for consistency (also Betty never uses the method itself)
  • Make AssetRepository an interface and refactor the existing class into a concrete implementation.
  • add a decorator for Project.assets

Blocked by

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels May 24, 2024
@bartfeenstra bartfeenstra changed the title Increase fs API performance Increase Assets API performance Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant