Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GrampsLoader's ability to accept an Ancestry instead of a Project #1586

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #1357

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Jun 21, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review June 21, 2024 17:06
Copy link

Uploaded Betty for commit e08d3cc. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (4f4e092) to head (e08d3cc).
Report is 4 commits behind head on 0.4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            0.4.x    #1586      +/-   ##
==========================================
+ Coverage   95.52%   95.54%   +0.01%     
==========================================
  Files         199      199              
  Lines       19181    19174       -7     
  Branches     3659     3658       -1     
==========================================
- Hits        18322    18319       -3     
+ Misses        590      587       -3     
+ Partials      269      268       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra merged commit 9555d4e into 0.4.x Jun 21, 2024
11 checks passed
@bartfeenstra bartfeenstra deleted the grampsloader-project-only branch June 21, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require a Project for GrampsLoader
1 participant