Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require a Project for GrampsLoader #1357

Closed
bartfeenstra opened this issue Mar 27, 2024 · 0 comments · Fixed by #1586
Closed

Require a Project for GrampsLoader #1357

bartfeenstra opened this issue Mar 27, 2024 · 0 comments · Fixed by #1586
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request good first issue Good for newcomers python Pull requests that update Python code
Milestone
0.4.x

Comments

@bartfeenstra
Copy link
Owner

bartfeenstra commented Mar 27, 2024 •
edited
Loading

Definition of Done

  • Refactor the GrampsLoader initializer to no longer accept an Ancestry, but only Project.
  • Remove the deprecation warning

Blocked by

  • The 0.4.x branch being opened
@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations python Pull requests that update Python code labels Mar 27, 2024
@bartfeenstra bartfeenstra added this to the 0.4.0 milestone Mar 27, 2024
@bartfeenstra bartfeenstra added the good first issue Good for newcomers label Mar 27, 2024
@bartfeenstra bartfeenstra modified the milestones: NEXT, 0.4.0 May 19, 2024
@bartfeenstra bartfeenstra mentioned this issue Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Milestone
0.4.x
Development

Successfully merging a pull request may close this issue.

Remove GrampsLoader's ability to accept an Ancestry instead of a Project bartfeenstra/betty
1 participant
@bartfeenstra