Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref to arxiv paper #80

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Add ref to arxiv paper #80

merged 4 commits into from
Mar 10, 2023

Conversation

arnaudon
Copy link
Collaborator

No description provided.

@arnaudon arnaudon requested a review from d-schindler March 10, 2023 07:25
@arnaudon
Copy link
Collaborator Author

@d-schindler , anywhere else we should add the citation?

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #80 (55bcbaa) into master (b5d0c1e) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##            master       #80   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          612       612           
=========================================
  Hits           612       612           
Flag Coverage Δ
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arnaudon
Copy link
Collaborator Author

@d-schindler , do you see where it crashes the test? If you retrigger, it works, this is very odd. I'm not sure why, if you want to try to have a guess at it, you're welcome!

@d-schindler
Copy link
Collaborator

@d-schindler , anywhere else we should add the citation?

I think it's fine like that.

@d-schindler , do you see where it crashes the test? If you retrigger, it works, this is very odd. I'm not sure why, if you want to try to have a guess at it, you're welcome!

Where do I see at which operation the test crashes? Is it still about the eigendecomposition?

@arnaudon arnaudon merged commit 13309cc into master Mar 10, 2023
@arnaudon arnaudon deleted the paper branch March 10, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants