[fix] Update bincode #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorawit
previously requested changes
Sep 5, 2024
colmazia
reviewed
Sep 5, 2024
colmazia
reviewed
Sep 5, 2024
RogerKSI
reviewed
Sep 5, 2024
RogerKSI
approved these changes
Sep 5, 2024
colmazia
approved these changes
Sep 5, 2024
warittornc
added a commit
that referenced
this pull request
Sep 6, 2024
* minor changes * [!feat] Update Binance (#58) * modify binance * minor change * fix * minor changes and add doc * remove unnecessary traits * simplify to single store * simplify to single store * refactor * remove anyhow and cleanup * fix * fix comment and cleanup * minor move * fix doc * fix comments * fix and format * add ids to log * rename set to add * added more descriptive doc for builder opts * fixed typo * fixed * add disconnect on exit * cleanup * grammer fix * add verbose error * change type from T to K * format * fix * cleanup * fix comments * change error to warn * [!feat] Refactor CoinGecko (#60) * [!feat] Minor Specification Changes (#62) * update proto * minor changes * regenerate proto * [!feat] Refactor Kraken (#61) * refactor kraken * add more comments * store multiple assetinfos at once, add unit tests * fix worker type spec * [!feat] Refactor API (#63) refactor api * [fix] Update bincode (#66) * minor cleanup * added extra logging * update bincode * fixed formating and minor refactor * fixed var name --------- Co-authored-by: Ongart Pisansathienwong <ongart.pisan@gmail.com>
colmazia
added a commit
that referenced
this pull request
Sep 25, 2024
* minor changes * [!feat] Update Binance (#58) * modify binance * minor change * fix * minor changes and add doc * remove unnecessary traits * simplify to single store * simplify to single store * refactor * remove anyhow and cleanup * fix * fix comment and cleanup * minor move * fix doc * fix comments * fix and format * add ids to log * rename set to add * added more descriptive doc for builder opts * fixed typo * fixed * add disconnect on exit * cleanup * grammer fix * add verbose error * change type from T to K * format * fix * cleanup * fix comments * change error to warn * [!feat] Refactor CoinGecko (#60) * [!feat] Minor Specification Changes (#62) * update proto * minor changes * regenerate proto * [!feat] Refactor Kraken (#61) * refactor kraken * add more comments * store multiple assetinfos at once, add unit tests * fix worker type spec * implement okx refactoring * add unit tests * delete unnecessary files * [!feat] Refactor API (#63) refactor api * update okx to match new bothan * [fix] Update bincode (#66) * minor cleanup * added extra logging * update bincode * fixed formating and minor refactor * fixed var name * fix from comments * fix merging bug * fix members order * fix Cargo.toml * fix from comments * fix default timeout * change websocket connection error --------- Co-authored-by: Warittorn Cheevachaipimol <warittorn@bandprotocol.com> Co-authored-by: warittornc <69615455+warittornc@users.noreply.github.com> Co-authored-by: Kitipong Sirirueangsakul <kitipong.sirir@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG.mdFiles changedtab in the GitHub PR explorer)