[!feat] Update Binance #58

warittornc · 2024-07-03T09:50:04Z

Implementation details

Do 1
Do 2

Please ensure the following requirements are met before submitting a pull request:

The pull request is targeted against the correct target branch
The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
The pull request includes a description of the implementation/work done in detail.
The pull request includes any appropriate unit/integration tests
You have added a relevant changelog entry to CHANGELOG.md
You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the GitHub PR explorer)

sorawit

Some comments

bothan-binance/src/store/builder.rs

bothan-binance/src/store.rs

bothan-binance/src/store/asset_store.rs

bothan-binance/src/store/builder.rs

bothan-binance/Cargo.toml

bothan-binance/src/store.rs

bothan-core/src/store.rs

bothan-binance/src/store/asset_worker.rs

bothan-binance/src/worker.rs

bothan-binance/src/api/types.rs

bothan-binance/src/api/websocket.rs

bothan-binance/src/worker.rs

bothan-binance/src/worker/asset_worker.rs

bothan-core/src/utils.rs

bothan-binance/src/worker.rs

bothan-binance/src/worker/asset_worker.rs

sorawit

lgtm

bothan-binance/src/api/websocket.rs

bothan-binance/src/worker/asset_worker.rs

bothan-core/src/store.rs

bothan-binance/src/worker.rs

bothan-core/src/worker.rs

bothan-core/src/store.rs

bothan-binance/src/api/error.rs

bothan-binance/src/worker/builder.rs

bothan-binance/src/api/websocket.rs

bothan-binance/src/worker/asset_worker.rs

sorawit · 2024-07-08T03:46:06Z

lgtm. will leave it to @taobun / @RogerKSI to approve

bothan-binance/src/api/error.rs

bothan-binance/src/worker/builder.rs

* minor changes * [!feat] Update Binance (#58) * modify binance * minor change * fix * minor changes and add doc * remove unnecessary traits * simplify to single store * simplify to single store * refactor * remove anyhow and cleanup * fix * fix comment and cleanup * minor move * fix doc * fix comments * fix and format * add ids to log * rename set to add * added more descriptive doc for builder opts * fixed typo * fixed * add disconnect on exit * cleanup * grammer fix * add verbose error * change type from T to K * format * fix * cleanup * fix comments * change error to warn * [!feat] Refactor CoinGecko (#60) * [!feat] Minor Specification Changes (#62) * update proto * minor changes * regenerate proto * [!feat] Refactor Kraken (#61) * refactor kraken * add more comments * store multiple assetinfos at once, add unit tests * fix worker type spec * [!feat] Refactor API (#63) refactor api * [fix] Update bincode (#66) * minor cleanup * added extra logging * update bincode * fixed formating and minor refactor * fixed var name --------- Co-authored-by: Ongart Pisansathienwong <ongart.pisan@gmail.com>

* minor changes * [!feat] Update Binance (#58) * modify binance * minor change * fix * minor changes and add doc * remove unnecessary traits * simplify to single store * simplify to single store * refactor * remove anyhow and cleanup * fix * fix comment and cleanup * minor move * fix doc * fix comments * fix and format * add ids to log * rename set to add * added more descriptive doc for builder opts * fixed typo * fixed * add disconnect on exit * cleanup * grammer fix * add verbose error * change type from T to K * format * fix * cleanup * fix comments * change error to warn * [!feat] Refactor CoinGecko (#60) * [!feat] Minor Specification Changes (#62) * update proto * minor changes * regenerate proto * [!feat] Refactor Kraken (#61) * refactor kraken * add more comments * store multiple assetinfos at once, add unit tests * fix worker type spec * implement okx refactoring * add unit tests * delete unnecessary files * [!feat] Refactor API (#63) refactor api * update okx to match new bothan * [fix] Update bincode (#66) * minor cleanup * added extra logging * update bincode * fixed formating and minor refactor * fixed var name * fix from comments * fix merging bug * fix members order * fix Cargo.toml * fix from comments * fix default timeout * change websocket connection error --------- Co-authored-by: Warittorn Cheevachaipimol <warittorn@bandprotocol.com> Co-authored-by: warittornc <69615455+warittornc@users.noreply.github.com> Co-authored-by: Kitipong Sirirueangsakul <kitipong.sirir@gmail.com>

* minor changes * [!feat] Update Binance (#58) * modify binance * minor change * fix * minor changes and add doc * remove unnecessary traits * simplify to single store * simplify to single store * refactor * remove anyhow and cleanup * fix * fix comment and cleanup * minor move * fix doc * fix comments * fix and format * add ids to log * rename set to add * added more descriptive doc for builder opts * fixed typo * fixed * add disconnect on exit * cleanup * grammer fix * add verbose error * change type from T to K * format * fix * cleanup * fix comments * change error to warn * [!feat] Refactor CoinGecko (#60) * [!feat] Minor Specification Changes (#62) * update proto * minor changes * regenerate proto * [!feat] Refactor Kraken (#61) * refactor kraken * add more comments * store multiple assetinfos at once, add unit tests * fix worker type spec * implement coinbase refactoring * add unit tests * [!feat] Refactor API (#63) refactor api * update coinbase to match new bothan * fix format * fix merging bug * fix merged files * fix from comments in update-okx * fix format * change default timeout * fix from comments * fix websocket connection error * fix decimal error name --------- Co-authored-by: Warittorn Cheevachaipimol <warittorn@bandprotocol.com> Co-authored-by: warittornc <69615455+warittornc@users.noreply.github.com>

warittornc added 3 commits July 3, 2024 16:26

modify binance

6f4f09d

minor change

81ef3a8

fix

b48d389

warittornc requested review from taobun and RogerKSI July 3, 2024 09:50

warittornc marked this pull request as draft July 3, 2024 09:51

minor changes and add doc

8bc81a2

warittornc requested a review from sorawit July 4, 2024 05:52

warittornc added 3 commits July 4, 2024 12:54

remove unnecessary traits

21ecca9

simplify to single store

348bad7

simplify to single store

5513ff8

sorawit requested changes Jul 4, 2024

View reviewed changes

warittornc added 3 commits July 4, 2024 16:37

refactor

6b696c5

remove anyhow and cleanup

a91ab9d

fix

ae0d3e2

sorawit requested changes Jul 4, 2024

View reviewed changes

bothan-binance/src/worker.rs Outdated Show resolved Hide resolved

fix comment and cleanup

953dbcb

warittornc requested a review from sorawit July 4, 2024 10:41

minor move

df05c21

warittornc marked this pull request as ready for review July 4, 2024 10:44

fix doc

7c7b2d3

sorawit requested changes Jul 4, 2024

View reviewed changes

bothan-core/src/utils.rs Outdated Show resolved Hide resolved

fix comments

0df7eaa

warittornc requested a review from sorawit July 4, 2024 15:57

fix and format

b1ef34b

sorawit requested changes Jul 4, 2024

View reviewed changes

bothan-binance/src/worker.rs Outdated Show resolved Hide resolved

bothan-binance/src/worker/asset_worker.rs Outdated Show resolved Hide resolved

warittornc added 2 commits July 5, 2024 01:38

add ids to log

898832f

rename set to add

3edd238

sorawit approved these changes Jul 5, 2024

View reviewed changes

bothan-binance/src/api/websocket.rs Outdated Show resolved Hide resolved

fixed typo

8ea262c

sorawit requested changes Jul 5, 2024

View reviewed changes

bothan-binance/src/worker/asset_worker.rs Show resolved Hide resolved

bothan-core/src/store.rs Outdated Show resolved Hide resolved

bothan-binance/src/worker.rs Outdated Show resolved Hide resolved

taobun requested changes Jul 5, 2024

View reviewed changes

fixed

55dafe2

RogerKSI requested changes Jul 5, 2024

View reviewed changes

bothan-binance/src/api/websocket.rs Outdated Show resolved Hide resolved

add disconnect on exit

e6a200e

warittornc requested review from RogerKSI and sorawit July 8, 2024 03:16

warittornc added 2 commits July 8, 2024 10:18

cleanup

944e686

grammer fix

305d00e

sorawit requested changes Jul 8, 2024

View reviewed changes

bothan-binance/src/worker/asset_worker.rs Outdated Show resolved Hide resolved

add verbose error

f37e190

warittornc requested a review from sorawit July 8, 2024 03:32

change type from T to K

1ce709c

warittornc requested a review from taobun July 8, 2024 06:14

warittornc added 3 commits July 8, 2024 15:51

format

2821b9f

fix

dead607

cleanup

607b351

taobun reviewed Jul 8, 2024

View reviewed changes

bothan-binance/src/api/error.rs Outdated Show resolved Hide resolved

bothan-binance/src/worker/builder.rs Outdated Show resolved Hide resolved

fix comments

010785c

taobun approved these changes Jul 8, 2024

View reviewed changes

RogerKSI approved these changes Jul 8, 2024

View reviewed changes

change error to warn

a39eb40

warittornc merged commit 8dd3c5d into update Jul 8, 2024
3 checks passed

warittornc deleted the update-binance branch July 8, 2024 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[!feat] Update Binance #58

[!feat] Update Binance #58

warittornc commented Jul 3, 2024

sorawit left a comment

sorawit left a comment

sorawit commented Jul 8, 2024

[!feat] Update Binance #58

[!feat] Update Binance #58

Conversation

warittornc commented Jul 3, 2024

Implementation details

Please ensure the following requirements are met before submitting a pull request:

sorawit left a comment

Choose a reason for hiding this comment

sorawit left a comment

Choose a reason for hiding this comment

sorawit commented Jul 8, 2024