Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GraphQL Subscriptions Incorrectly Closing the Connection When Stream Returns an Error #1014

Merged

Conversation

ThisaruGuruge
Copy link
Member

Purpose

When a stream.next() function returns an error, GraphQL service should send an error response and then continue to work. But currently, this will cause to service to close the connection.

Fixes: #3565

Examples

N/A

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 87.16% // Head: 87.15% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (1081cab) compared to base (0628cd2).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   87.16%   87.15%   -0.01%     
==========================================
  Files          59       59              
  Lines        4479     4485       +6     
  Branches     2443     2447       +4     
==========================================
+ Hits         3904     3909       +5     
- Misses        545      546       +1     
  Partials       30       30              
Impacted Files Coverage Δ
ballerina/executor_visitor.bal 85.13% <0.00%> (ø)
ballerina/websocket_service.bal 88.15% <90.00%> (-4.38%) ⬇️
ballerina/engine.bal 97.53% <100.00%> (ø)
ballerina/field.bal 100.00% <100.00%> (ø)
ballerina/websocket_utils.bal 98.38% <100.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ThisaruGuruge ThisaruGuruge merged commit 5685822 into ballerina-platform:master Oct 28, 2022
@ThisaruGuruge ThisaruGuruge deleted the stream-error-fix branch October 28, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL Subscriptions Close Connection Incorrectly when Stream Returns Error
3 participants