Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL Subscriptions Close Connection Incorrectly when Stream Returns Error #3565

Closed
ThisaruGuruge opened this issue Oct 27, 2022 · 0 comments · Fixed by ballerina-platform/module-ballerina-graphql#1014
Closed

GraphQL Subscriptions Close Connection Incorrectly when Stream Returns Error #3565

ThisaruGuruge opened this issue Oct 27, 2022 · 0 comments · Fixed by ballerina-platform/module-ballerina-graphql#1014
Assignees
@ThisaruGuruge
Labels
module/graphql Issues related to Ballerina GraphQL module Points/1 Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/PCM Protocol connector packages related issues Type/Bug
Milestone
2201.3.0

Comments

@ThisaruGuruge
Copy link
Member

ThisaruGuruge commented Oct 27, 2022 •
edited
Loading

Description:
When a next() function of a stream returns an error, the GraphQL service closes the connection. This is incorrect. It should send the error and continue.

Effected Versions

GraphQL 1.4.3
@ThisaruGuruge ThisaruGuruge added Points/1 Type/Bug module/graphql Issues related to Ballerina GraphQL module Team/PCM Protocol connector packages related issues labels Oct 27, 2022
@ThisaruGuruge ThisaruGuruge self-assigned this Oct 27, 2022
@ThisaruGuruge ThisaruGuruge added the Reason/EngineeringMistake The issue occurred due to a mistake made in the past. label Oct 27, 2022
This was referenced Oct 27, 2022
Merged
Merged
@ThisaruGuruge ThisaruGuruge added this to the 2201.3.0 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThisaruGuruge ThisaruGuruge

Labels
module/graphql Issues related to Ballerina GraphQL module Points/1 Reason/EngineeringMistake The issue occurred due to a mistake made in the past. Team/PCM Protocol connector packages related issues Type/Bug
Projects
Ballerina Team Main Board
Archived in project
Milestone
2201.3.0
1 participant
@ThisaruGuruge