migrate some services from examples to openApi part 46; affects [codeclimate librariesio nexus] and securityheaders #9933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
service-badge
|
|
🚀 Updated review app: https://pr-9933-badges-shields.fly.dev |
For example: |
chris48s
changed the title
|
OK. Thanks for the pointer. I think I mostly figured it out 🤞 |
chris48s
commented
Feb 11, 2024
| @@ -269,7 +267,7 @@ t.create('Nexus 3 - search snapshot version valid snapshot artifact') | |||
|
|
|||
| t.create('Nexus 3 - search snapshot version for artifact without snapshots') | |||
| .get( | |||
| '/s/javax.inject/javax.inject.json?server=https://nexus.pentaho.org&nexusVersion=3', | |||
| '/s/com.tomkeuper/spigot.json?server=https://repo.tomkeuper.com&nexusVersion=3', | |||
There was a problem hiding this comment.
This is the one I am least sure if I got right. It does appear to throw the right error message.
| @@ -46,7 +46,7 @@ t.create('test coverage when outer user repos query returns multiple items') | |||
| }, | |||
| latest_default_branch_test_report: { | |||
| data: { | |||
| id: '6463c8a3e3bc340001004bce', | |||
| id: '65a1662cb0077b00013cb4de', | |||
There was a problem hiding this comment.
I feel like this is not a sustainable solution for this test, but I think I'm not going to deal with re-writing this test in this PR as it is a bit of a yak-shave that isn't really related to the original point of this PR.
PyvesB
approved these changes
Feb 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #9285
With nexus, we don't have passing tests for nexus v3
I have actually managed to find a couple of public nexus servers running v3:
but I can't work out how to get a working badge out of either of them.
With Security Headers, the tests fail because the badges themselves are broken #9154 I figure lets just migrate the examples here and leave that as an issue for another time.