Fully mock flaky [CodeClimate] multi-step tests #10218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyvesB
added
the
keep-service-tests-green
chris48s
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced these two tests in #7716, but unfortunately they've broken a few times already (#9253, #9933, and presently broken again). This probably boils down to the fact that the snapshot and test report IDs we use in the first mocked response eventually get cleaned up, making the second non-mocked query fail. I suggest we fully mock these tests, they exercise logic for edge cases so don't benefit from hitting the real upstream services as much anyway.
Closes #7833.