Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a pages/ folder in scss and includes it in global.scss #204

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

aurooba
Copy link
Collaborator

@aurooba aurooba commented May 29, 2023

Closes #203

@aurooba aurooba requested a review from bacoords May 29, 2023 18:57
@aurooba
Copy link
Collaborator Author

aurooba commented Jun 1, 2023

Sooooo I feel like we should include a page mod or something here to demonstrate the reason for this folder to exist.

@bacoords
Copy link
Owner

bacoords commented Jun 1, 2023

The first page mod I typically add is a 'no-title' page template that removes all upper/lower padding so you can do full marketing pages.

@aurooba
Copy link
Collaborator Author

aurooba commented Jun 1, 2023

Ooh yeah, that's a good one. Once 6.3 comes out and the title is optional, it'll all become a little easier, but yeah totes. Do you want to add that into this PR or do create a new issue?

@bacoords
Copy link
Owner

bacoords commented Jun 1, 2023

Do you have a link to a PR/Issues for that title thing?

@aurooba
Copy link
Collaborator Author

aurooba commented Jun 1, 2023

Errr. I definitely saw it somewhere, but..I can't find it anywhere. I do know that Matt M said the post title would eventually become optional, and there are various issues discussing this, such as WordPress/gutenberg#28564.

But perhaps I'm mistaken about this landing in 6.3.

@aurooba
Copy link
Collaborator Author

aurooba commented Jun 1, 2023

Also WordPress/gutenberg#27093

@bacoords bacoords merged commit c92c56e into develop Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pages/ folder with an empty index.scss in src/scss
2 participants