-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move post/page title to the top bar. #27093
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
It might also be good to include the template information here, and a link to view all posts. post.title.mp4 |
This comment was marked as resolved.
This comment was marked as resolved.
It may be fine to leave the post title on the canvas for now. Otherwise I imagine the text would read "Untitled Page" (or similar) until you click it. Clicking should shift focus directly to the title input. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
That might work! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
That's correct :) |
Hello all, I created a pull request for this issue: #46135 It's the most basic implementation for now. Would love to get additional eyes on it and see what you all think ✨ |
Hello all, I just reviewed the PR and gave some technical/accessibility feedback. Keeping in mind that I can't see the screenshots, I am interested to see how close the PR got to the actual visual design. From an UX perspective, it greatly worries me that we continue to box up the editor. It is going to get harder and harder to provide context around that as we'll soon require a bunch of random/very generic button labels to convey where we've decided to hide certain functionality/options. I am not saying wide open always works better, but I am not sure the post title hidden in an accordion-like drop down was the right way to go here. In my opinion, I think it would be nice to leave the title field where it currently is. It is a nice buffer between main document title and the start of the editing fun. Thoughts? Thanks. |
The issue with the current placement of the title field is that it breaks the WYSIWYG. The proposed solution re-uses existing Site Editor features (updating the title of a custom template), but I assume those also suffer from the same accessibility issues? An alternative option could be to simply move the title field into the top bar? Hopefully we could position it in the DOM so that it still acts as a buffer? title.mp4 |
@jameskoster Might be best to just move the field in to the top bar. I am not sure hiding it in a drop down is really necessary at this point. All my other A11Y feedback on the PR still applies. Need to figure out how to not mess up the DOM structure. Thanks. |
Assuming we can get the other a11y details right, I think it would be okay to start with that. Thanks for the detailed feedback as always. Edit: to clarify, which of these points would remain if the input was moved into the top bar?
The first, third and fourth issues should be resolved because the "Edit document details" button wouldn't be required any more. Issue #2 should be easy to address, we can position the title input anywhere in the top bar and use css for ordering / styling. For the fifth issue, how do you know how to save the title changes currently? |
I think that Alex has a good handle on the accessibility of the title interface. I'm comfortable in principle with moving the title out of the post editor; it was a separate field in the classic editor, and keeping it separate seems totally reasonable to me. My primary concern is making sure that the title has sufficient prominence, so that it's easy to spot at a glance which document you're editing and that there's no truncation of the title, so that the entire post title is always visible. Having the title directly editable in the top bar makes sense to me. I can also imagine that this layout could speed things up in a work flow where you're stubbing out a large number of documents to be filled out later, since you wouldn't need to enter the post editor in order to publish a stub that only had a title. |
I agree with @joedolson. As a user, I wouldn't know the title was immediately editable without some kind of indication, so having it as an input makes sense to me. I updated the pull request with that implementation so we can all see what that looks like as we keep the discussion going.
I believe having it as an input also addresses this fifth issue raised by @alexstine. If the title is an input, I feel that folks could intuit that one needs to save the post in order to persist edits to it. |
@annezazu, @ndiego, based on the discussion in PR #46135 (comment), I believe this path was deprioritized in favor of a broader solution. I think we can remove the issue from WP 6.2 project board. |
Yeah, at the very least, it does not look like a solution will make it into 6.2 at this point. I'll remove it. |
Can we close this issue? The editor now has a Document bar displaying the title + new rename action in the sidebar. |
I think there are opportunities for putting a rename action in the title area again, though the precise mechanism for doing so needs a little thought as it also opens the command palette. I don't know if that means we keep this issue open or not. |
I personally like the current design and functionality of the document bar. @jasmussen, as you mentioned, the click is already attached to the command palette. In the future, maybe renaming action can be a command. @youknowriad, any thoughts? |
Agreed that a contextual command seems like a natural approach here. |
Block themes and template editing give authors much more freedom to express how the titles of posts and pages are displayed on the frontend. They might appear inside Cover blocks, adjacent to Post Content, or in any other conceivable block configuration. There are also situations in which a template might not display a post title at all, e.g. Post Formats.
All that to say, it might be time to consider not displaying the post title within the canvas when editing a post or page, because the current implementation is increasingly unlikely to be an accurate representation of the frontend. Example:
Clearly it must still be possible to edit the post title without engaging the template editor first. For a solution we can look to the Site Editor, where the document name appears in the Top Bar, and custom templates can be renamed:
We can probably migrate this pattern across to the post editor as well. The result would be something like this:
When the document has no title, the label can probably read something like "Untitled Document".
Original issue
I think it makes sense to move the page/post title into the top bar like we do for template names. Often we will want to add the Post title inside another block (e.g. Cover block), or in a column.This would give users more flexibility about where the Post/Page title appears:
Originally suggested by @paaljoachim here: #20877 (comment)
The text was updated successfully, but these errors were encountered: