[WIP] Move title to header toolbar #31288
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Size Change: +758 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
vdwijngaert
force-pushed
the
try/move-title-to-toolbar
branch
from
2a0db0d to
03ce5b9
Compare
|
This is what I see: Title-in-top-bar.mp4Should the top bar title be centered in the top bar area? |
|
Hey Kerry @gwwar , Joen @jasmussen and George @Mamaduka |
|
Hi, Paal @paaljoachim As far as I can tell, this is still a work in progress. But will be happy to review/test once it reaches the first stable point. |
|
I have a lot of work on my plate the next couple of days, so I'll like be unable to resume work on this until at least Friday 14/5. Contributions, suggestions and/or advice on what's already here is welcome. I think we could reuse the |
|
Based on some recent issues and my general knowledge, duplication is sometimes better than early abstraction. |
|
I'll ping a few folks who have worked/work on Full Site Editing who can give some advice. |
^^ This. We have heard this a lot when moving existing edit-post functionality to edit-site. So I wouldn't worry too much about copying the edit-site component code or moving it to another package to share. Its probably best to just implement this in edit-post for now and we can always consolidate later if the need arises. |
|
It would be great to get some movement on this PR! |
7 tasks
vdwijngaert
force-pushed
the
try/move-title-to-toolbar
branch
from
6f0de99 to
4fee83e
Compare
|
This is what I see using Chrome and a local test site using Twenty Nineteen. Title-top-bar.mp4Title-top-bar-remove-title-shows-loading.mp4 |
|
Status-update (see the issue):
Obviously, having to duplicate code from some Site Editor components is less than ideal. In the future, it might make sense to have both editors use the same components for this, but I'm not familiar enough with the way that should work on an architectural level. If this is a priority, I'd like some feedback on that. Like I said, I still need to go over some of the styling rules. Right now I've used some rules from the Edit: @paaljoachim, I fixed the loading... issue as well. |
|
This is a lot better @vdwijngaert Koen! Title-top-bar.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR gives a go at moving the management of the entity title to the header toolbar area, as described in #27093.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).