Fixed reusing node in destructuring plugin, which caused caching issu… #6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5160/ |
existentialism
added
the
PR: Bug Fix 🐛
…e in helper-module-transforms
existentialism
approved these changes
Oct 3, 2017
nicolo-ribaudo
approved these changes
Oct 3, 2017
|
Niiiice, thanks for the quick fix! 👌 |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e in helper-module-transforms
I thought about lifting this cloning into a function which would be called in each
push*method to obtain a cloned node, but I couldn't reproduce issue in any other scenario (but there are just so many I could have not thought of, so...). So i've chosen not to be too aggressive about this cloning for now, however it could potentially save us from other headaches in the future.Please try to break my build (or master) with any other, similar, code 😄