Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel 7 #137

Closed
codejunkienick opened this issue Nov 16, 2017 · 8 comments
Closed

Babel 7 #137

codejunkienick opened this issue Nov 16, 2017 · 8 comments

Comments

@codejunkienick
Copy link

Is this still being prepared for babel 7 support? it's in beta now so would be worth preparing this plugin. Right now I get _getClassName is not defined whenever I use conditional stylenames

@gajus
Copy link
Owner

gajus commented Nov 16, 2017

Is this still being prepared for babel 7 support? it's in beta now so would be worth preparing this plugin. Right now I get _getClassName is not defined whenever I use conditional stylenames

I am not going to have time for this upgrade any time soon. Therefore, PR is welcome.

@cjanik
Copy link

cjanik commented Dec 13, 2017

I might be interested in contributing to this. Right now I have no familiarity with the plugin source though. Any ideas what the scope of the issue is, or where to start?

@gajus
Copy link
Owner

gajus commented Dec 13, 2017

@loganfsmyth
Copy link

loganfsmyth commented Jan 8, 2018

For anyone looking to jump into this, I'll throw out a guess that this is similar to the issue in babel/babel#6374 where the same _getClassName Identifier node is inserted into multiple places in the tree. The fix is probably the same. Needs calls to t.clone to copy the identifier each place that it is inserted into the AST. No need to break compatibility with 6 at least.

@IanVS
Copy link
Contributor

IanVS commented Dec 1, 2018

I'm guessing this can be closed now, right?

@gajus gajus closed this as completed Dec 1, 2018
@gajus
Copy link
Owner

gajus commented Dec 1, 2018

I'm guessing this can be closed now, right?

This plugin doesn't support Babel 7, though.

@gajus gajus reopened this Dec 1, 2018
@IanVS
Copy link
Contributor

IanVS commented Dec 1, 2018

Then what do the 4.0.0 release notes mean?

BREAKING CHANGES
babel 7 requirement

Also, I just upgraded and it seems to work fine.

@gajus
Copy link
Owner

gajus commented Dec 1, 2018

Never mind. Juggling too many projects at once.

@gajus gajus closed this as completed Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants