Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ds model card, rebased #2101

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Add ds model card, rebased #2101

merged 6 commits into from
Dec 3, 2024

Conversation

bursteratom
Copy link
Collaborator

Description

Continuation of PR#1015,#2094 with rebasing

Motivation and Context

How has this been tested?

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

@bursteratom bursteratom mentioned this pull request Nov 24, 2024
@bursteratom bursteratom marked this pull request as draft November 24, 2024 20:52
@bursteratom bursteratom marked this pull request as ready for review November 25, 2024 01:08
@bursteratom bursteratom requested a review from winglian November 25, 2024 01:08
@bursteratom bursteratom requested a review from winglian November 26, 2024 03:06
Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winglian winglian merged commit ff4794c into main Dec 3, 2024
13 checks passed
@winglian winglian deleted the add_ds_model_card_2 branch December 3, 2024 05:02
bursteratom added a commit that referenced this pull request Dec 4, 2024
* rebased add_ds_model_card

* manual rebasing

* fix redundancy

* lint

* include case when ds_tag is none

* conform to kwargs in create_model_card
bursteratom added a commit that referenced this pull request Dec 4, 2024
* rebased add_ds_model_card

* manual rebasing

* fix redundancy

* lint

* include case when ds_tag is none

* conform to kwargs in create_model_card
djsaunde pushed a commit that referenced this pull request Dec 16, 2024
* rebased add_ds_model_card

* manual rebasing

* fix redundancy

* lint

* include case when ds_tag is none

* conform to kwargs in create_model_card
djsaunde pushed a commit that referenced this pull request Dec 17, 2024
* rebased add_ds_model_card

* manual rebasing

* fix redundancy

* lint

* include case when ds_tag is none

* conform to kwargs in create_model_card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants