-
-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ds model card #2094
Add ds model card #2094
Conversation
@winglian this is a temporary WIP patch, the proper way will probably be actually parsing dataset_tags into the trainer for proper kwarg sanitising, I think. Do you think it's necessary? |
Why skip for dpo? Let's make sure to properly handle that case too. |
@winglian trl trainer's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are too many unrelated changes in this PR from doing a merge commit. Please resolve and re-request a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should have no edits, you have some errors in your merge commit. I personally prefer to rebase branches rather than merge commits to avoid issues like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saem as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saem as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saem as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saem as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saem as above.
to be continued with rebasing here: #2101 |
Continuation of PR#1015 with rebasing
Description
Add dataset tagging to model card for both local and push to huggingface hub.
https://github.com/huggingface/hub-docs/blob/main/modelcard.md
Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)