Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting (WIP - not ready for review) #28

Closed
wants to merge 2 commits into from
Closed

linting (WIP - not ready for review) #28

wants to merge 2 commits into from

Conversation

diehbria
Copy link
Contributor

@diehbria diehbria commented Jan 5, 2022

Linting, build system improvements

Overview

  • Enforce linting on mono-repo level test, to ensure that the github test workflow fails when linting rules are not appplied
  • Append components.d.ts to ignore, because this is an auto-generated file.
  • Fix linting commands at mono-repo level
  • Apply missing linting rules
  • Fix accidental rebase on testing-ground from @NorbertNader comment on feat: api simplification of requestSettings #27

Legal

This project is available under the Apache 2.0 License.

@diehbria diehbria marked this pull request as draft January 5, 2022 01:31
@diehbria diehbria changed the title linting linting (WIP - not ready for review) Jan 5, 2022
Copy link
Contributor

@gareth-amazon gareth-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@diehbria diehbria closed this Jan 5, 2022
@diehbria diehbria deleted the linting branch May 5, 2022 16:26
sheilaXu pushed a commit that referenced this pull request Sep 23, 2022
Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases)
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/terser/terser/commits)

---
updated-dependencies:
- dependency-name: terser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants