feat: api simplification of requestSettings #27
Conversation
diehbria
requested review from
NorbertNader,
boweihan,
gareth-amazon and
fpauer
| </select> | ||
| <div style={{ width: '400px', height: '500px' }}> | ||
| <iot-line-chart | ||
| appKit={this.dataModule} | ||
| query={AGGREGATED_DATA_QUERY} | ||
| viewport={this.viewport} | ||
| requestConfig={{ resolution: this.resolution, fetchAggregatedData: true }} | ||
| viewport={VIEWPORT} |
There was a problem hiding this comment.
Could we leave this as this.viewport? Didn't want it to be static so we can play around with different viewports to test resolution mapping.
There was a problem hiding this comment.
yup, I believe this was an accidental rebase
There was a problem hiding this comment.
I will switch this back to this.viewport in my next commit, merged this in to prevent any additional conflicts with the linting
| } | ||
| }; | ||
|
|
||
| public subscribeToDataStreamsFrom = (source: string, callback: DataStreamCallback) => { |
There was a problem hiding this comment.
What was the purpose of this? Just a deprecated version of subscribeToDataStreams?
There was a problem hiding this comment.
not quite - you can read more about it in https://quip-amazon.com/rFRTAJ7StHtb/IoT-App-Kit but not going to tackle that for initial release
| try { | ||
| await Promise.all(requests); | ||
| } catch (err) { | ||
| // NOOP |
There was a problem hiding this comment.
Should we do the same for aggregated and latest?
There was a problem hiding this comment.
i'll revisit this one and get back to you on it
Overview
API work on core
Utilize the originally planned API structure, with settings such as
fetchFromStartToEnd,fetchMostRecentBeforeEnd,fetchMostRecentBeforeStart, etc.,Legal
This project is available under the Apache 2.0 License.