Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in public headers #60

Merged
merged 4 commits into from
May 15, 2023
Merged

Fix warnings in public headers #60

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb50785
Add macro in public headers
waahm7 May 9, 2023
16391ca
blank line
waahm7 May 9, 2023
9f6b03a
update builder
waahm7 May 10, 2023
91cc604
add extern c begin & end
waahm7 May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- 'main'

env:
BUILDER_VERSION: v0.9.40
BUILDER_VERSION: v0.9.43
BUILDER_SOURCE: releases
BUILDER_HOST: https://d19elf31gohf1l.cloudfront.net
PACKAGE_NAME: aws-c-compression
Expand Down
4 changes: 4 additions & 0 deletions include/aws/compression/compression.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

#include <aws/common/common.h>

AWS_PUSH_SANE_WARNING_LEVEL

#define AWS_C_COMPRESSION_PACKAGE_ID 3

enum aws_compression_error {
Expand All @@ -32,4 +34,6 @@ void aws_compression_library_init(struct aws_allocator *alloc);
AWS_COMPRESSION_API
void aws_compression_library_clean_up(void);

AWS_POP_SANE_WARNING_LEVEL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file's lacking AWS_EXTERN_C_BEGIN/END

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.


#endif /* AWS_COMPRESSION_COMPRESSION_H */
3 changes: 3 additions & 0 deletions include/aws/compression/huffman.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

#include <aws/common/byte_buf.h>

AWS_PUSH_SANE_WARNING_LEVEL

/**
* Represents an encoded code
*/
Expand Down Expand Up @@ -157,5 +159,6 @@ AWS_COMPRESSION_API
void aws_huffman_decoder_allow_growth(struct aws_huffman_decoder *decoder, bool allow_growth);

AWS_EXTERN_C_END
AWS_POP_SANE_WARNING_LEVEL

#endif /* AWS_COMPRESSION_HUFFMAN_H */