Fix warnings in public headers #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waahm7
changed the title
graebm
approved these changes
May 12, 2023
| @@ -32,4 +34,6 @@ void aws_compression_library_init(struct aws_allocator *alloc); | |||
| AWS_COMPRESSION_API | |||
| void aws_compression_library_clean_up(void); | |||
|
|
|||
| AWS_POP_SANE_WARNING_LEVEL | |||
There was a problem hiding this comment.
this file's lacking AWS_EXTERN_C_BEGIN/END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
AWS_PUSH_SANE_WARNING_LEVELandAWS_POP_SANE_WARNING_LEVELto the public headers. The public header should contain at least one include; otherwise, we will receive a macro not found error. Therefore, I decided to skip adding these macros if there are no includes.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.