Merge account management work #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement "Registered Accounts" admin page
List admin accounts UI
List pending requests UI
(The "ensureCustomerItem backfills UserPoolId" test has been removed since we no longer require backfilling UserPoolId.)
Implement account management backend
All the various extensions listed in the docs are also supported, including Postman extensions, x-amazon-apigateway-integration extensions, x-amazon-apigateway-authorizers extensions, and combinations of all three. You can also choose whether to export as YAML or JSON. It's a separate dropdown, but reuses the same modal, and it just delegates to AWS in a lambda to generate the export. (The logic is nearly identical to the SDK generation.)
ghost
requested review from
a-tan,
etsung-aws,
jiyou95,
MynockSpit and
skylarbemus
as code owners
|
Note: this only needs 1 review, not 2. (@skylarbemus reviewed it in the last PR) |
jiyou95
approved these changes
Mar 6, 2020
added 5 commits
March 6, 2020 10:46
Also, make `/admin` a proper redirect to `/admin/apis` instead of letting it just be an alias.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #355 (closed due to my own error)