List admin accounts UI #303
Conversation
alex-chew
requested review from
bejos-zz,
etsung-aws,
MynockSpit,
nitishdayal and
echo-bravo-yahoo
as code owners
|
|
||
| /** | ||
| * Suppress React 16.8 act() warnings globally. | ||
| * The React team's fix won't be out of alpha until 16.9.0. |
There was a problem hiding this comment.
Note that 16.9.0 is out, and breaks nothing while obviating the need for this warning suppression utility. However, our Semantic UI React dependency (and perhaps others) uses features deprecated in 16.9.0, and so deprecation warnings appear during tests. I would prefer to wait until all of our dependencies are fully compatible with 16.9.0, before upgrading.
| render: ({ promoterIdentityPoolId, promoterEmailAddress }) => | ||
| promoterIdentityPoolId | ||
| ? `${promoterEmailAddress} (${promoterIdentityPoolId})` | ||
| : '', |
There was a problem hiding this comment.
Should this be empty string or throw / display error modal? This represents a pretty horrific edge case, right (we have a user with no identity pool ID or email address...)?
There was a problem hiding this comment.
Not quite - there will always be at least one Account without a promoter, which is the initial Admin account. (There can be more if added via the Cognito dashboard, or carried forward during migration.)
Description of changes:
This PR introduces UI and tests for listing accounts in the Admin user pool group.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.